Messages in this thread | | | Date | Sun, 1 Oct 2023 08:36:23 +0200 | Subject | Re: [PATCH 3/5] cxgb4: Annotate struct cxgb4_tc_u32_table with __counted_by | From | "Gustavo A. R. Silva" <> |
| |
On 9/29/23 20:11, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct cxgb4_tc_u32_table. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Raju Rangoju <rajur@chelsio.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks -- Gustavo
> --- > drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h > index f59dd4b2ae6f..9050568a034c 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h > @@ -331,6 +331,6 @@ struct cxgb4_link { > > struct cxgb4_tc_u32_table { > unsigned int size; /* number of entries in table */ > - struct cxgb4_link table[]; /* Jump table */ > + struct cxgb4_link table[] __counted_by(size); /* Jump table */ > }; > #endif /* __CXGB4_TC_U32_PARSE_H */
| |