Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 1 Oct 2023 17:32:53 +0300 | Subject | Re: [PATCH RFC v4 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors |
| |
On Sun, Oct 1, 2023 at 5:13 PM Duje Mihanović <duje.mihanovic@skole.hr> wrote: > > Sharp's Spitz board still uses the legacy GPIO interface for controlling > a GPIO pin related to the USB host controller. > > Convert this function to use the new GPIO descriptor interface.
...
> + pxa_ohci->usb_host = gpiod_get_optional(&pdev->dev, "usb-host", GPIOD_OUT_LOW); > + if (IS_ERR(pxa_ohci->usb_host)) > + dev_warn(&pdev->dev, "failed to get USB host GPIO with %pe\n", > + pxa_ohci->usb_host);
Since you are using _optional() API, you need to bail out on the error case and replace dev_warn() by dev_err(). I guess I already commented on this. What is the rationale to not follow my comment?
-- With Best Regards, Andy Shevchenko
| |