Messages in this thread | | | Date | Mon, 9 Jan 2023 17:06:03 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v1 1/1] leds: is31fl319x: Wrap mutex_destroy() for devm_add_action_or_rest() |
| |
On Wed, 28 Dec 2022, Andy Shevchenko wrote:
> Clang complains that devm_add_action() takes a parameter with a wrong type: > > warning: cast from 'void (*)(struct mutex *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict] > err = devm_add_action(dev, (void (*)(void *))mutex_destroy, &is31->lock); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 warning generated. > > It appears that the commit e1af5c815586 ("leds: is31fl319x: Fix devm vs. > non-devm ordering") missed two things: > - while mention devm_add_action_or_reset() the actual change got > devm_add_action() call by unknown reason > - strictly speaking the parameter is not compatible by type
I fixed-up the wording above a little.
> Fix both issues by switching to devm_add_action_or_reset() and adding a > wrapper for mutex_destroy() call. > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: e1af5c815586 ("leds: is31fl319x: Fix devm vs. non-devm ordering") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Tested-by: Vincent Knecht <vincent.knecht@mailoo.org> > --- > > v2: added tag (Vincent), Cc'ed to Lee > > drivers/leds/leds-is31fl319x.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-)
Applied, thanks
-- Lee Jones [李琼斯]
| |