lkml.org 
[lkml]   [2023]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 00/11] Remove AS_EIO and AS_ENOSPC
From
Date
On Mon, 2023-01-09 at 05:18 +0000, Matthew Wilcox (Oracle) wrote:
> Finish the work of converting every user to the "new" wb_err
> infrastructure. This will clash with Christoph's patch series to remove
> folio_write_one(), so I'll redo this after that patch series goes in.
>
> Matthew Wilcox (Oracle) (11):
> memory-failure: Remove comment referencing AS_EIO
> filemap: Remove filemap_check_and_keep_errors()
> f2fs: Convert f2fs_wait_on_node_pages_writeback() to errseq
> fuse: Convert fuse_flush() to use file_check_and_advance_wb_err()
> page-writeback: Convert folio_write_one() to use an errseq
> filemap: Convert filemap_write_and_wait_range() to use errseq
> filemap: Convert filemap_fdatawait_range() to errseq
> cifs: Remove call to filemap_check_wb_err()
> mm: Remove AS_EIO and AS_ENOSPC
> mm: Remove filemap_fdatawait_range_keep_errors()

> mm: Remove filemap_fdatawait_keep_errors()
>
> block/bdev.c | 8 +--
> fs/btrfs/extent_io.c | 6 +--
> fs/cifs/file.c | 8 ++-
> fs/f2fs/data.c | 2 +-
> fs/f2fs/node.c | 4 +-
> fs/fs-writeback.c | 7 +--
> fs/fuse/file.c | 3 +-
> fs/jbd2/commit.c | 12 ++---
> fs/xfs/scrub/bmap.c | 2 +-
> include/linux/pagemap.h | 23 ++------
> mm/filemap.c | 113 +++++++---------------------------------
> mm/memory-failure.c | 28 ----------
> mm/page-writeback.c | 17 +++---
> 13 files changed, 51 insertions(+), 182 deletions(-)
>

Now that I got my understanding straight about unseen errors, I think
this looks good. I think it'd be best to avoid advancing f_wb_err in
->flush operations but the rest of this looks fine.

You can add this to all but #4 (and that one should be easily fixable).

Reviewed-by: Jeff Layton <jlayton@kernel.org>

\
 
 \ /
  Last update: 2023-03-26 23:33    [W:0.130 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site