Messages in this thread | | | Date | Mon, 9 Jan 2023 15:29:44 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH v4 net-next 2/3] net: dsa: mv88e6xxx: shorten the locked section in mv88e6xxx_g1_atu_prob_irq_thread_fn() |
| |
On Sun, Jan 08, 2023 at 10:48:48AM +0100, Hans J. Schultz wrote: > As only the hardware access functions up til and including > mv88e6xxx_g1_atu_mac_read() called under the interrupt handler > need to take the chip lock, we release the chip lock after this call. > The follow up code that handles the violations can run without the > chip lock held. > In further patches, the violation handler function will even be > incompatible with having the chip lock held. This due to an AB/BA > ordering inversion with rtnl_lock(). > > Signed-off-by: Hans J. Schultz <netdev@kapio-technology.com> > ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
| |