Messages in this thread | | | From | Dave Stevenson <> | Date | Mon, 9 Jan 2023 10:32:37 +0000 | Subject | Re: [PATCH 08/15] drm/vc4: hvs: Ignore atomic_flush if we're disabled |
| |
Hi Maxime
On Wed, 7 Dec 2022 at 11:55, Maxime Ripard <maxime@cerno.tech> wrote: > > atomic_flush will be called for each CRTC even if they aren't enabled. > > The whole code we have there will thus run without a properly affected > channel, which can then result in all sorts of weird behaviour. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> --- > drivers/gpu/drm/vc4/vc4_hvs.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c > index 3582ede1a0aa..5fadbf219542 100644 > --- a/drivers/gpu/drm/vc4/vc4_hvs.c > +++ b/drivers/gpu/drm/vc4/vc4_hvs.c > @@ -579,6 +579,9 @@ void vc4_hvs_atomic_flush(struct drm_crtc *crtc, > return; > } > > + if (vc4_state->assigned_channel == VC4_HVS_CHANNEL_DISABLED) > + return; > + > if (debug_dump_regs) { > DRM_INFO("CRTC %d HVS before:\n", drm_crtc_index(crtc)); > vc4_hvs_dump_state(hvs); > > -- > 2.38.1
| |