Messages in this thread | | | Date | Mon, 9 Jan 2023 09:48:51 +0000 | Subject | Re: [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values | From | Srinivas Kandagatla <> |
| |
Hi Rafal,
On 06/01/2023 19:15, Rafał Miłecki wrote: > Hi Srinivas, > > On 2022-11-11 18:41, Srinivas Kandagatla wrote: >> On 12/10/2022 16:51, INAGAKI Hiroshi wrote: >>> This patch fixes crc32 error on Big-Endianness system by conversion of >>> calculated crc32 value. >>> >>> Little-Endianness system: >>> >>> obtained crc32: Little >>> calculated crc32: Little >>> >>> Big-Endianness system: >>> >>> obtained crc32: Little >>> calculated crc32: Big >>> >>> log (APRESIA ApresiaLightGS120GT-SS, RTL8382M, Big-Endianness): >>> >>> [ 8.570000] u_boot_env >>> 18001200.spi:flash@0:partitions:partition@c0000: Invalid calculated >>> CRC32: 0x88cd6f09 (expected: 0x096fcd88) >>> [ 8.580000] u_boot_env: probe of >>> 18001200.spi:flash@0:partitions:partition@c0000 failed with error -22 >>> >>> Fixes: f955dc1445069 ("nvmem: add driver handling U-Boot environment >>> variables") >>> >>> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com> >>> --- >> >> Applied thanks, > > has this patch been lost somewhere in the process? > > I'm quite sure I saw it in linux-next.git and probably in nvmem.git. Now > it seems to be gone. Yes, I had to revert this one as next reported sparse warnings [1] with this patch which were not addressed.
--srini
[1] https://lore.kernel.org/linux-mm/202212040713.rVney9e8-lkp@intel.com/T/
| |