Messages in this thread | | | Date | Mon, 09 Jan 2023 09:49:00 +0100 | From | Michael Walle <> | Subject | Re: [PATCH v2] mtd: spi-nor: macronix: add support for mx77l51250f |
| |
Am 2023-01-07 22:43, schrieb Tomas Winkler: > $ cat /sys/bus/spi/devices/spi0.0/spi-nor/partname > mx77l51250f > $ cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id > c2751a > $ cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer > macronix > $ xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp > 53464450060103ff00060110300000ffc2000104100100ff030001020001 > 00ff84000102c00000ffffffffffffffffffe520f3ffffffff1f44eb086b > 083b04bbeeffffffffff00ffffff00ff0c200f5210d800ff8341bd0082a7 > 04db4403373830b030b0f7a9d55c009e29fff050f985ffffffffffffffff > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff > ffffffffffffffffffffffff7f0ff0ff215cdcffffffffffffffffffffff > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff > ffffffffffffffffffffffffffffffff3c9b96f0c5a4c2ffffffffffffff > ffff003600279df9c064fecfffffffffffff > > $ md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp > 36fb8e3e6f82c45bfabea45ec73c08a8 > /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
Thanks for the dumps, as Dhruva mentioned this should go in the comment section of this patch. But also see below.
> --- a/drivers/mtd/spi-nor/macronix.c > +++ b/drivers/mtd/spi-nor/macronix.c > @@ -100,6 +100,8 @@ static const struct flash_info macronix_nor_parts[] > = { > { "mx66u2g45g", INFO(0xc2253c, 0, 64 * 1024, 4096) > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) > FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, > + { "mx77l51250f", INFO(0xc2751a, 0, 64 * 1024, 4096) > + PARSE_SFDP },
With the newest generic spi nor driver [1] this patch shouldn't be needed at all anymore. Could you verify, that your flash will work without it?
-michael
[1] https://elixir.bootlin.com/linux/v6.2-rc3/source/drivers/mtd/spi-nor/core.c#L1637
| |