Messages in this thread | | | Date | Mon, 9 Jan 2023 09:46:54 +0100 | Subject | Re: commit 3497b9a5 (usb: dwc3: add power down scale setting) breaks imx8mp | From | Rasmus Villemoes <> |
| |
On 06/01/2023 14.35, Jun Li wrote: > > >> -----Original Message----- >> From: Rasmus Villemoes <rasmus.villemoes@prevas.dk> >> Sent: Friday, January 6, 2023 7:55 PM >> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Jun Li >> <jun.li@nxp.com>
>> Li Jun, please either revert 3497b9a5 or figure out if imx8mp.dtsi is broken >> and needs a fix similar to 74bd5951dd3. > > iMX8MP suspend clock(with name IMX8MP_CLK_USB_ROOT) was 32K when 3497b9a5 > was merged, a later iMX8MP clock driver patch change the clock to be root > clock gate(actually this is a shared clock gate for both suspend and root > clock), so break the iMX8MP USB as you are seeing, a fix patch set already > addressed this issue, please check and apply below 3 patches: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/dt-bindings/clock/imx8mp-clock.h?id=5c1f7f1090947d494c30042123e0ec846f696336 > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/clk/imx/clk-imx8mp.c?id=ed1f4ccfe947a3e1018a3bd7325134574c7ff9b3 > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/arm64/boot/dts/freescale/imx8mp.dtsi?id=8a1ed98fe0f2e7669f0409de0f46f317b275f8be
Thanks, I see that the first two are in 6.2-rc1 and have already been picked up in 6.0.y and 6.1.y. The last is not yet in mainline and thus not eligible for -stable, but does seem to be included in Shawn's PR
https://lore.kernel.org/all/20230102132016.GA10699@T480/
so I assume that it will land shortly.
Rasmus
| |