Messages in this thread | | | Date | Mon, 9 Jan 2023 19:48:34 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next] net/rds: use strscpy() to instead of strncpy() |
| |
On Mon, 9 Jan 2023 19:48:43 +0800 (CST) yang.yang29@zte.com.cn wrote: > BUG_ON(strlen(names[i]) >= sizeof(ctr.name)); > - strncpy(ctr.name, names[i], sizeof(ctr.name) - 1); > - ctr.name[sizeof(ctr.name) - 1] = '\0'; > + strscpy(ctr.name, names[i], sizeof(ctr.name));
You can make use of the fact that strscpy returns useful information and the copy and the preceding BUG_ON() together.
| |