Messages in this thread | | | Date | Tue, 10 Jan 2023 09:45:11 +0800 | From | Leo Yan <> | Subject | Re: [PATCH 1/2] perf kmem: Support legacy tracepoints |
| |
On Mon, Jan 09, 2023 at 12:38:04PM -0300, Arnaldo Carvalho de Melo wrote:
[...]
> > > + const char * const slab_legacy_events[] = { > > > + "-e", "kmem:kmalloc_node", > > > + "-e", "kmem:kmem_cache_alloc_node", > > > + }; > > > > Reviewed-by: James Clark <james.clark@arm.com> > > > > This fixes the error with mem:kmalloc_node for me.
Thanks for reviewing and testing!
> > I was thinking that it might be best to add all events to the list > > conditionally instead of just the legacy ones. That way, the same error > > won't happen in the future. But maybe it's best to have an explicit > > error again in case the breaking change was unintentional so it's fine > > as it is I think.
Yeah, this is a good idea for refactoring.
James, do you mind to send patches for this?
> Just applied this, the changes you brains stormed may come as later > patches, thanks,
Thanks, Arnaldo.
Leo
| |