Messages in this thread | | | From | "Wang, Haiyue" <> | Subject | RE: [PATCH bpf-next v1] bpf: Remove the unnecessary insn buffer comparison | Date | Mon, 9 Jan 2023 23:52:43 +0000 |
| |
> -----Original Message----- > From: sdf@google.com <sdf@google.com> > Sent: Tuesday, January 10, 2023 01:39 > To: Wang, Haiyue <haiyue.wang@intel.com> > Cc: bpf@vger.kernel.org; Alexei Starovoitov <ast@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>; > Andrii Nakryiko <andrii@kernel.org>; Martin KaFai Lau <martin.lau@linux.dev>; Song Liu > <song@kernel.org>; Yonghong Song <yhs@fb.com>; John Fastabend <john.fastabend@gmail.com>; KP Singh > <kpsingh@kernel.org>; Hao Luo <haoluo@google.com>; Jiri Olsa <jolsa@kernel.org>; David S. Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo > Abeni <pabeni@redhat.com>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH bpf-next v1] bpf: Remove the unnecessary insn buffer comparison > > On 01/08, Haiyue Wang wrote: > > The variable 'insn' is initialized to 'insn_buf' without being changed, > > only some helper macros are defined, so the insn buffer comparison is > > unnecessary, just remove it. > > > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> > > Acked-by: Stanislav Fomichev <sdf@google.com> > > Looks like these should have been removed as part of commit 2377b81de527 > ("bpf: split shared bpf_tcp_sock and bpf_sock_ops implementation"). >
Thanks for the information, yes, it was missed. ;-)
> > --- > > net/core/filter.c | 6 ------ > > 1 file changed, 6 deletions(-) >
> > -- > > 2.39.0
| |