Messages in this thread | | | Date | Mon, 9 Jan 2023 19:05:14 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v13 1/2] docs: Add block device (blkdev) LED trigger documentation |
| |
Hi!
This is the crazy interface I'm complaining about:
> * /sys/class/leds/<led>/link_dev_by_path > * /sys/class/leds/<led>/unlink_dev_by_path > * /sys/class/leds/<led>/unlink_dev_by_name > * /sys/class/leds/<led>/linked_devices
Echoing filenames into files (with symlink resolution) is quite strange, is it? As is having two different unlink interfaces.
I believe we do have other places handling similar N:M configuration problems, so this should be similar to some of them.
Obvious improvement would be having only "link_dev_by_name" and "unlink_dev_by_name", but then, unlink should really be rm.
Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates. [unhandled content-type:application/pgp-signature] | |