Messages in this thread | | | Subject | Re: [PATCH 01/16] dt-bindings: spi: Convert bcm63xx-hsspi bindings to json-schema | From | William Zhang <> | Date | Sun, 8 Jan 2023 23:52:27 -0800 |
| |
On 01/07/2023 07:32 AM, Krzysztof Kozlowski wrote: > On 06/01/2023 21:07, William Zhang wrote: >> This is the preparation for updates on the bcm63xx hsspi driver. Convert >> the text based bindings to json-schema per new dts requirement. >> >> Signed-off-by: William Zhang <william.zhang@broadcom.com> >> --- >> >> .../bindings/spi/brcm,bcm63xx-hsspi.yaml | 52 +++++++++++++++++++ >> .../bindings/spi/spi-bcm63xx-hsspi.txt | 33 ------------ >> 2 files changed, 52 insertions(+), 33 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml >> delete mode 100644 Documentation/devicetree/bindings/spi/spi-bcm63xx-hsspi.txt >> >> diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml >> new file mode 100644 >> index 000000000000..45f1417b1213 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml >> @@ -0,0 +1,52 @@ >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/spi/brcm,bcm63xx-hsspi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Broadcom BCM6328 High Speed SPI controller >> + >> +maintainers: >> + - Jonas Gorski <jonas.gorski@gmail.com> >> + > > Missing reference to spi-controller. > This was word to word conversion from the text file. But I will update with this required reference.
>> +properties: >> + compatible: >> + const: brcm,bcm6328-hsspi >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: spi master reference clock >> + - description: spi master pll clock >> + >> + clock-names: >> + items: >> + - const: hsspi >> + - const: pll >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - interrupts >> + >> +unevaluatedProperties: false > > This is for cases when you have reference to other schema. > Will drop here. But will add back in patch 1 which produces the final version of this file and need this property.
> > Best regards, > Krzysztof > [unhandled content-type:application/pkcs7-signature]
| |