lkml.org 
[lkml]   [2023]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] mce: fix missing stack-dumping in mce_panic()
Date
>> Maybe then I can look at some way to suppress the oops dump for the "useless"
>> cases? Or perhaps at least add an extra message that stack dumps from arbitrary
>> machine checks are rarely useful.
>
> IMHO the user will always expect a stack dump when system panic. I'm afraid that if these
> "useless" cases are eliminated, it will cause user confused and trying to find what eats
> the stack dump?

What about the "extra message" option? Always print the full oops. but for ones from
mce_panic() arrange somehow to add an extra bit of helpful text. Something like this:

1) For poison consumption in kernel code:

"The reason for this panic is consumption of poisoned data by the kernel"

2) For the general machine check case:

"The reason for this panic is a hardware detected error reported as a machine check.
Note that the stack and register dumps are likely useless to diagnose the root cause
of this panic."

-Tony
\
 
 \ /
  Last update: 2023-03-26 23:32    [W:2.084 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site