lkml.org 
[lkml]   [2023]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/13] staging: r8188eu: bkq_cnt is write-only
    Date
    bkq_cnt in struct xmit_priv is initialised, incremented and decremented
    but never read. Remove bkq_cnt and resulting dead code.

    Signed-off-by: Martin Kaiser <martin@kaiser.cx>
    ---
    drivers/staging/r8188eu/core/rtw_xmit.c | 1 -
    drivers/staging/r8188eu/include/rtw_xmit.h | 1 -
    drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 4 ----
    3 files changed, 6 deletions(-)

    diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
    index e5ac49441337..875675656d11 100644
    --- a/drivers/staging/r8188eu/core/rtw_xmit.c
    +++ b/drivers/staging/r8188eu/core/rtw_xmit.c
    @@ -195,7 +195,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
    pxmitpriv->txirp_cnt = 1;

    /* per AC pending irp */
    - pxmitpriv->bkq_cnt = 0;
    pxmitpriv->viq_cnt = 0;
    pxmitpriv->voq_cnt = 0;

    diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h
    index c84f73f2cc59..3d56c3afaf7d 100644
    --- a/drivers/staging/r8188eu/include/rtw_xmit.h
    +++ b/drivers/staging/r8188eu/include/rtw_xmit.h
    @@ -282,7 +282,6 @@ struct xmit_priv {
    u8 txirp_cnt;/* */
    struct tasklet_struct xmit_tasklet;
    /* per AC pending irp */
    - int bkq_cnt;
    int viq_cnt;
    int voq_cnt;
    struct __queue free_xmitbuf_queue;
    diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
    index 067b7def2bde..5ae09edf9174 100644
    --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
    +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
    @@ -48,9 +48,6 @@ static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs)
    case VI_QUEUE_INX:
    pxmitpriv->viq_cnt--;
    break;
    - case BK_QUEUE_INX:
    - pxmitpriv->bkq_cnt--;
    - break;
    case HIGH_QUEUE_INX:
    rtw_chk_hi_queue_cmd(padapter);
    break;
    @@ -123,7 +120,6 @@ u32 rtw_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem)
    pxmitbuf->flags = BE_QUEUE_INX;
    break;
    case BK_QUEUE_INX:
    - pxmitpriv->bkq_cnt++;
    pxmitbuf->flags = BK_QUEUE_INX;
    break;
    case HIGH_QUEUE_INX:
    --
    2.30.2
    \
     
     \ /
      Last update: 2023-03-26 23:32    [W:5.147 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site