[lkml]   [2023]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 3/6] x86/microcode: Display revisions only when update is successful

* Borislav Petkov <> wrote:

> On Fri, Jan 06, 2023 at 12:29:00PM -0800, Ashok Raj wrote:
> > Yes, that makes sense, Do you think we can add a note that the loading
> > failed? since the old -> new, new is coming from new microcode rev.
> It has failed when
> old == new.
> I.e.,
> "microcode revision: 0x1a -> 0x1a"
> when the current revision on the CPU is 0x1a.

So wouldn't it make sense to also display the fact that the microcode
loading failed?

Seeing '0x1a -> 0x1a' one might naively assume from the wording alone that
it got "reloaded" or somehow reset, or that there's some sub-revision
update that isn't visible in the revision version - when in fact nothing
happened, right?

The kernel usually tries to tell users unambigiously when some requested
operation didn't succeed - not just hint at it somewhat



 \ /
  Last update: 2023-03-26 23:31    [W:0.086 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site