Messages in this thread Patch in this message |  | | From | Tom Rix <> | Subject | [PATCH] habanalabs: remove redundant memset | Date | Sat, 7 Jan 2023 13:48:27 -0500 |
| |
From reviewing the code, the line memset(kdata, 0, usize); is not needed because kdata is either zeroed by kdata = kzalloc(asize, GFP_KERNEL); when allocated at runtime or by char stack_kdata[128] = {0}; at compile time.
Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/accel/habanalabs/common/habanalabs_ioctl.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/accel/habanalabs/common/habanalabs_ioctl.c b/drivers/accel/habanalabs/common/habanalabs_ioctl.c index 619d56c40b30..949d38527160 100644 --- a/drivers/accel/habanalabs/common/habanalabs_ioctl.c +++ b/drivers/accel/habanalabs/common/habanalabs_ioctl.c @@ -1123,8 +1123,6 @@ static long _hl_ioctl(struct file *filep, unsigned int cmd, unsigned long arg, retcode = -EFAULT; goto out_err; } - } else if (cmd & IOC_OUT) { - memset(kdata, 0, usize); } retcode = func(hpriv, kdata); -- 2.27.0
|  |