Messages in this thread |  | | Date | Sat, 7 Jan 2023 11:36:51 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH block/for-6.2-fixes] block: Drop spurious might_sleep() from blk_put_queue() |
| |
On Fri, Jan 06, 2023 at 12:45:12PM -0800, Luis Chamberlain wrote: > > Signed-off-by: Tejun Heo <tj@kernel.org> > > Reported-by: Dan Carpenter <error27@gmail.com> > > Link: https://lkml.kernel.org/r/Y7g3L6fntnTtOm63@kili > > Cc: Christoph Hellwig <hch@lst.de> > > Cc: Luis Chamberlain <mcgrof@kernel.org> > > Fixes: e8c7d14ac6c3 ("block: revert back to synchronous request_queue removal") # v5.9+ > > *tons* has changed since e8c7d14ac6c3 and so the bots might think that > *if* this patch is applied upstream it is justified for older kernels > and I don't think that's yet been verified and doubt it.
If you enable the correct debug option then the might_sleep() causes a stack trace. Eventually syzbot will find it.
I would backport it.
regards, dan carpenter
|  |