Messages in this thread |  | | From | Miguel Ojeda <> | Date | Sat, 7 Jan 2023 15:45:17 +0100 | Subject | Re: [PATCH] kbuild: rust: move rust/target.json to scripts/ |
| |
On Sat, Jan 7, 2023 at 10:43 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > I usually do not add $(objtree)/. > > include/config/auto.conf is also a generated file. > > It is inconsistent to add $(objtree)/ > to scripts/generate_rust_target, > but not to include/config/auto.conf. > > (obj)/target.json: $(objtree)/scripts/generate_rust_target > $(objtree)/include/config/auto.conf FORCE > $(call filechk,rust_target) > > is annoying.
Being consistent sounds good to me, and I agree there are already a lot of `$`s around in `Makefile`s... :)
In general, I tend to prefer explicit over implicit -- it would make non-prefixed paths less ambiguous on whether they are relative or anchored to the root. And I guess it could help reduce confusion, e.g. `arch/powerpc/boot/Makefile` mentions:
# clean-files are relative to $(obj).
Either way, it is fine. Thanks a lot for explaining the logic! I just sent a quick patch for Kbuild docs since I noticed it was outdated regarding `objtree` for `clean-files`.
Cheers, Miguel
|  |