Messages in this thread | | | Date | Sat, 7 Jan 2023 01:51:36 +0900 | Subject | Re: [PATCH v6 4/5] arm64: dts: apple: t600x: Add PWM controller | From | Hector Martin <> |
| |
On 06/01/2023 22.58, Sasha Finkelstein wrote: > Adds PWM controller and keyboard backlight bindings for M1 Pro/Max MacBook Pros > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > --- > arch/arm64/boot/dts/apple/t600x-die0.dtsi | 9 +++++++++ > arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi | 18 ++++++++++++++++++ > 2 files changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/apple/t600x-die0.dtsi b/arch/arm64/boot/dts/apple/t600x-die0.dtsi > index 1c41954e3899..7065045dc43a 100644 > --- a/arch/arm64/boot/dts/apple/t600x-die0.dtsi > +++ b/arch/arm64/boot/dts/apple/t600x-die0.dtsi > @@ -154,6 +154,15 @@ i2c5: i2c@39b054000 { > status = "disabled"; > }; > > + fpwm0: pwm@39b030000 { > + compatible = "apple,t6000-fpwm", "apple,s5l-fpwm"; > + reg = <0x3 0x9b030000 0x0 0x4000>; > + power-domains = <&ps_fpwm0>; > + clocks = <&clkref>; > + #pwm-cells = <2>; > + status = "disabled"; > + }; > +
We usually keep device nodes sorted by address, so this is out of order and should come before i2c (at least). No need to respin just for this though, I can fix it when I apply it, so:
Acked-by: Hector Martin <marcan@marcan.st>
Maintainers: as we usually ask, please merge only the driver commit (#2) via the PWM tree, we'll take care of DTs/MAINTAINERS/bindings via asahi-soc so we can avoid serializing/blocking other DT changes.
- Hector
| |