Messages in this thread | | | Date | Fri, 6 Jan 2023 13:38:38 +0100 | Subject | Re: [PATCH v3 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names | From | Krzysztof Kozlowski <> |
| |
On 06/01/2023 03:59, Yanhong Wang wrote: > Some boards(such as StarFive VisionFive v2) require more than one value > which defined by resets property, so the original definition can not > meet the requirements. In order to adapt to different requirements, > adjust the maxitems number definition. > > Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 36 ++++++++++++++----- > 1 file changed, 28 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index e26c3e76ebb7..f7693e8c8d6d 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -132,14 +132,6 @@ properties: > - pclk > - ptp_ref > > - resets: > - maxItems: 1 > - description: > - MAC Reset signal. > - > - reset-names: > - const: stmmaceth
Do not remove properties from top-level properties. Instead these should have widest constraints which are further constrain in allOf:if:then.
Here you should list items with minItems: 1.
> -
Best regards, Krzysztof
| |