Messages in this thread Patch in this message | | | From | Divya Koppera <> | Subject | [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret | Date | Fri, 6 Jan 2023 13:59:04 +0530 |
| |
Initialized return variable
Fixes Old smatch warnings: drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error: uninitialized symbol 'ret'.
Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com> --- v5 -> v6: - Removed fixes tag as this is fixing static analysis issus and not a real fix.
v4 -> v5: - No changes, added reviewed by tag.
v3 -> v4: - Split the patch for different warnings.
v1 -> v3: - No changes --- drivers/net/phy/micrel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 26ce0c5defcd..1bcdb828db56 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -2088,7 +2088,8 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev, const struct kszphy_type *type = phydev->drv->driver_data; unsigned long pair_mask = type->pair_mask; int retries = 20; - int pair, ret; + int ret = 0; + int pair; *finished = false; -- 2.17.1
| |