lkml.org 
[lkml]   [2023]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 17/44] coredump: Convert to vma iterator
    Date
    From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

    Use the vma iterator so that the iterator can be invalidated or updated
    to avoid each caller doing so.

    Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
    ---
    fs/coredump.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/fs/coredump.c b/fs/coredump.c
    index de78bde2991b..f27d734f3102 100644
    --- a/fs/coredump.c
    +++ b/fs/coredump.c
    @@ -1111,14 +1111,14 @@ static unsigned long vma_dump_size(struct vm_area_struct *vma,
    * Helper function for iterating across a vma list. It ensures that the caller
    * will visit `gate_vma' prior to terminating the search.
    */
    -static struct vm_area_struct *coredump_next_vma(struct ma_state *mas,
    +static struct vm_area_struct *coredump_next_vma(struct vma_iterator *vmi,
    struct vm_area_struct *vma,
    struct vm_area_struct *gate_vma)
    {
    if (gate_vma && (vma == gate_vma))
    return NULL;

    - vma = mas_next(mas, ULONG_MAX);
    + vma = vma_next(vmi);
    if (vma)
    return vma;
    return gate_vma;
    @@ -1146,7 +1146,7 @@ static bool dump_vma_snapshot(struct coredump_params *cprm)
    {
    struct vm_area_struct *gate_vma, *vma = NULL;
    struct mm_struct *mm = current->mm;
    - MA_STATE(mas, &mm->mm_mt, 0, 0);
    + VMA_ITERATOR(vmi, mm, 0);
    int i = 0;

    /*
    @@ -1167,7 +1167,7 @@ static bool dump_vma_snapshot(struct coredump_params *cprm)
    return false;
    }

    - while ((vma = coredump_next_vma(&mas, vma, gate_vma)) != NULL) {
    + while ((vma = coredump_next_vma(&vmi, vma, gate_vma)) != NULL) {
    struct core_vma_metadata *m = cprm->vma_meta + i;

    m->start = vma->vm_start;
    --
    2.35.1
    \
     
     \ /
      Last update: 2023-03-26 23:29    [W:2.255 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site