Messages in this thread | | | Date | Thu, 5 Jan 2023 08:56:02 -0700 | Subject | Re: [PATCH 5/6] bus: mhi: ep: Move chan->lock to the start of processing queued ch ring | From | Jeffrey Hugo <> |
| |
On 12/28/2022 9:17 AM, Manivannan Sadhasivam wrote: > There is a good chance that while the channel ring gets processed, the STOP > or RESET command for the channel might be received from the MHI host. In > those cases, the entire channel ring processing needs to be protected by > chan->lock to prevent the race where the corresponding channel ring might > be reset. > > While at it, let's also add a sanity check to make sure that the ring is > started before processing it. Because, if the STOP/RESET command gets > processed while mhi_ep_ch_ring_worker() waited for chan->lock, the ring > would've been reset. > > Cc: <stable@vger.kernel.org> # 5.19 > Fixes: 03c0bb8ec983 ("bus: mhi: ep: Add support for processing channel rings") > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > ---
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
| |