Messages in this thread | | | Date | Thu, 5 Jan 2023 08:26:45 -0700 | Subject | Re: Linux 6.2-rc1 | From | Jens Axboe <> |
| |
On 1/5/23 4:25 AM, Greg Kroah-Hartman wrote: > On Wed, Jan 04, 2023 at 02:43:16PM -0700, Jens Axboe wrote: >>> The removal seems to revert cleanly, although it does require >>> reverting a few subsequent commits too (that removed code that only >>> pktcdvd used): >>> >>> git revert db1c7d779767 85d6ce58e493 f40eb99897af >>> >>> where we have >>> >>> db1c7d779767 block: bio_copy_data_iter >>> 85d6ce58e493 block: remove devnode callback from struct >>> block_device_operations >>> f40eb99897af pktcdvd: remove driver. >> >> I'll queue this up - and unless I hear valid complaints to why we should >> not just reinstate the driver for now, it'll go out with the next pull >> request. > > If you do revert these, watch out for a build warning from the driver > core when you revert this, I think there's a 'const' missing from > somewhere that you might have to add back in due to other driver core > changes.
The revert compiles cleanly, even merged with current master.
-- Jens Axboe
| |