Messages in this thread | | | Date | Thu, 5 Jan 2023 21:01:14 +0700 | From | Bagas Sanjaya <> | Subject | Re: [PATCH linux-next v2] s390/zcrypt: use strscpy() to instead of strncpy() |
| |
On Tue, Jan 03, 2023 at 10:51:21AM +0100, Heiko Carstens wrote: > On Tue, Jan 03, 2023 at 10:02:07AM +0800, yang.yang29@zte.com.cn wrote: > > From: Yang Yang <yang.yang29@zte.com> > > > > The implementation of strscpy() is more robust and safer. > > That's now the recommended way to copy NUL-terminated strings. > > > > Signed-off-by: Yang Yang <yang.yang29@zte.com> > > Signed-off-by: Xu Panda <xu.panda@zte.com.cn> > > --- > > chang for v2 > > - match the FROM with the Email > > You sent this from yang.yang29@zte.com.cn, but the sign-off is without the > ".cn" suffix. Can you please make sure that your sign-off chain actually > follows the rules as outlined in Documentation/process/submitting-patches.rst? > > If you read that then the sign-off line from Xu Panda shouldn't be there, > since the patch was not authored or routed via Xu Panda.
Specifically, the second SoB from Xu should only be included if he was in From: mail header (that is, he should have sent the patch instead of Yang).
Ah! Thanks for reminding me of this trivial issue that I always missed when reviewing ZTE patches.
Xu, are you really transporting Yang's patch?
Thanks.
-- An old man doll... just what I always wanted! - Clara [unhandled content-type:application/pgp-signature] | |