Messages in this thread | | | Date | Thu, 5 Jan 2023 07:32:07 +0100 | Subject | Re: [PATCH v5] serial: linflexuart: remove redundant uart type assignment | From | Jiri Slaby <> |
| |
On 04. 01. 23, 17:43, LIZHE wrote: > in linflex_config_port() the member variable type will be > assigned again. see linflex_connfig_port()
Please use capitals when you start a sentence. And periods at the ends of them.
> Signed-off-by: LIZHE <sensor1010@163.com>
No, Lizhe was fine (or use your Chinese name. We support unicode so that would be fine too, as Greg stated).
But you didn't include changelog to your previous v1-v4 patches; as stated by Ilpo.
> Link: https://lore.kernel.org/all/20230103170948.3777-1-sensor1010@163.com/ > --- > drivers/tty/serial/fsl_linflexuart.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c > index 6fc21b6684e6..34400cc6ac7f 100644 > --- a/drivers/tty/serial/fsl_linflexuart.c > +++ b/drivers/tty/serial/fsl_linflexuart.c > @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev) > return PTR_ERR(sport->membase); > > sport->dev = &pdev->dev; > - sport->type = PORT_LINFLEXUART; > sport->iotype = UPIO_MEM; > sport->irq = platform_get_irq(pdev, 0); > sport->ops = &linflex_pops;
-- js suse labs
| |