Messages in this thread | | | Date | Thu, 5 Jan 2023 15:13:59 +0200 | Subject | Re: [PATCH] firmware/psci: Don't register with debugfs if PSCI isn't available | From | Dmitry Baryshkov <> |
| |
On 05/01/2023 11:08, Marc Zyngier wrote: > Contrary to popular belief, PSCI is not a universal property of an > ARM/arm64 system. There is a garden variety of systems out there > that don't (or even cannot) implement it. > > I'm the first one deplore such a situation, but hey... > > On such systems, a "cat /sys/kernel/debug/psci" results in > fireworks, as no invocation callback is registered. > > Check for the invoke_psci_fn and psci_ops.get_version pointers > before registering with the debugfs subsystem, avoiding the > issue altogether. > > Fixes: 3137f2e60098 ("firmware/psci: Add debugfs support to ease debugging") > Reported-by: Hector Martin <marcan@marcan.st> > Signed-off-by: Marc Zyngier <maz@kernel.org> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| |