Messages in this thread Patch in this message | | | From | Bartosz Golaszewski <> | Subject | [PATCH 2/2] spi: spidev: remove debug messages that access spidev->spi without locking | Date | Thu, 5 Jan 2023 13:41:00 +0100 |
| |
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The two debug messages in spidev_open() dereference spidev->spi without taking the semaphore and without checking if it's not null. This can lead to a crash. Drop the messages as they're not needed - the user-space will get informed about ENOMEM with the syscall return value.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- drivers/spi/spidev.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index b71620f64ec9..29c6344ee8e8 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -604,7 +604,6 @@ static int spidev_open(struct inode *inode, struct file *filp) if (!spidev->tx_buffer) { spidev->tx_buffer = kmalloc(bufsiz, GFP_KERNEL); if (!spidev->tx_buffer) { - dev_dbg(&spidev->spi->dev, "open/ENOMEM\n"); status = -ENOMEM; goto err_find_dev; } @@ -613,7 +612,6 @@ static int spidev_open(struct inode *inode, struct file *filp) if (!spidev->rx_buffer) { spidev->rx_buffer = kmalloc(bufsiz, GFP_KERNEL); if (!spidev->rx_buffer) { - dev_dbg(&spidev->spi->dev, "open/ENOMEM\n"); status = -ENOMEM; goto err_alloc_rx_buf; } -- 2.37.2
| |