Messages in this thread | | | Subject | Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs | From | Holger Hoffstätte <> | Date | Thu, 5 Jan 2023 13:07:07 +0100 |
| |
On 2023-01-05 10:03, David Hildenbrand wrote: > On 05.01.23 03:39, Suren Baghdasaryan wrote: >> On Wed, Jan 4, 2023 at 5:38 PM Andrew Morton <akpm@linux-foundation.org> wrote: >>> >>> On Wed, 4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan <surenb@google.com> wrote: >>> >>>> free_anon_vma_name() is missing a check for anonymous shmem VMA which >>>> leads to a memory leak due to refcount not being dropped. Fix this by >>>> calling anon_vma_name_put() unconditionally. It will free vma->anon_name >>>> whenever it's non-NULL. >>>> >>>> Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") >>> >>> A cc:stable is appropriate here, yes? >> >> Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC >> stable to fix the previous -rc branch? >> > > No need for stable if it's not in a release kernel yet.
Commit d09e8ca6cb93 is in 6.1. The fix applies cleanly.
cheers Holger
| |