lkml.org 
[lkml]   [2023]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter for new rules
[ Email re-arranged because I screwed up - dan]

On Thu, Jan 05, 2023 at 11:43:17AM +0100, Steen Hegelund wrote:

> This series was first sent to net, but the response was that I should go into
> net-next instead, so it is really a first version in net-next.
>
> What was your question? I was not able to find it...

Ugh... Oauth2 code (mutt/msmtp) silently ate my email. Sorry.

> > > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule)
> > >       ret = vcap_write_rule(ri);
> > >       if (ret)
> > >               pr_err("%s:%d: rule write error: %d\n", __func__, __LINE__,
> > > ret);

There should be a "goto out;" after the pr_err().

> > > +     /* Set the counter to zero */
> > > +     ret = vcap_write_counter(ri, &ctr);
> > >  out:
> > >       mutex_unlock(&ri->admin->lock);
> > >       return ret;
> >

regards,
dan carpenter

\
 
 \ /
  Last update: 2023-03-26 23:28    [W:0.073 / U:0.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site