Messages in this thread | | | From | "G, GurucharanX" <> | Subject | RE: [Intel-wired-lan] [PATCH net v4] ice: Add check for kzalloc | Date | Thu, 5 Jan 2023 05:52:13 +0000 |
| |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Jiasheng Jiang > Sent: Thursday, December 8, 2022 7:06 PM > To: jiri@resnulli.us > Cc: leon@kernel.org; intel-wired-lan@lists.osuosl.org; Jiasheng Jiang > <jiasheng@iscas.ac.cn>; Brandeburg, Jesse <jesse.brandeburg@intel.com>; > linux-kernel@vger.kernel.org; edumazet@google.com; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; netdev@vger.kernel.org; kuba@kernel.org; > pabeni@redhat.com; davem@davemloft.net > Subject: [Intel-wired-lan] [PATCH net v4] ice: Add check for kzalloc > > Add the check for the return value of kzalloc in order to avoid NULL pointer > dereference. > Moreover, use the goto-label to share the clean code. > > Fixes: d6b98c8d242a ("ice: add write functionality for GNSS TTY") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > --- > Changelog: > > v3 -> v4: > > 1. Move the check right after the kzalloc. > > v2 -> v3: > > 1. Use "while (i--)" to simplify the code. > > v1 -> v2: > > 1. Use goto-label to share the clean code. > --- > drivers/net/ethernet/intel/ice/ice_gnss.c | 23 ++++++++++++++--------- > 1 file changed, 14 insertions(+), 9 deletions(-) >
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
| |