Messages in this thread | | | Date | Thu, 5 Jan 2023 11:03:46 +0200 | From | Leon Romanovsky <> | Subject | Re: [PATCH net-next 3/5] drivers/net/phy: add connection between ethtool and phylib for PLCA |
| |
On Wed, Jan 04, 2023 at 03:06:30PM +0100, Piergiorgio Beruto wrote: > This patch adds the required connection between netlink ethtool and > phylib to resolve PLCA get/set config and get status messages. > > Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail.com> > --- > drivers/net/phy/phy.c | 172 +++++++++++++++++++++++++++++++++++ > drivers/net/phy/phy_device.c | 3 + > include/linux/phy.h | 7 ++ > 3 files changed, 182 insertions(+)
<...>
> + curr_plca_cfg = kmalloc(sizeof(*curr_plca_cfg), GFP_KERNEL); > + if (unlikely(!curr_plca_cfg)) {
Please don't put likely/unlikely on kamlloc and/or in in control path flow.
Thanks
| |