Messages in this thread Patch in this message | | | From | Kees Cook <> | Subject | [PATCH] vt: Replace 0-length array with flexible array | Date | Thu, 5 Jan 2023 14:05:54 -0800 |
| |
Zero-length arrays are deprecated[1]. Replace struct uni_screen's "lines" 0-length array with a flexible array. Detected with GCC 13, using -fstrict-flex-arrays=3:
../drivers/tty/vt/vt.c: In function 'vc_uniscr_copy_area': ../drivers/tty/vt/vt.c:488:48: warning: array subscript dst_row is outside array bounds of 'char32_t *[0]' {aka 'unsigned int *[]'} [-Warray-bounds=] 488 | char32_t *dst_line = dst->lines[dst_row]; | ~~~~~~~~~~^~~~~~~~~ ../drivers/tty/vt/vt.c:335:19: note: while referencing 'lines' 335 | char32_t *lines[0]; | ^~~~~
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jirislaby@kernel.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> Cc: Helge Deller <deller@gmx.de> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> Signed-off-by: Kees Cook <keescook@chromium.org> --- drivers/tty/vt/vt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 981d2bfcf9a5..b1445f00f616 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -332,7 +332,7 @@ typedef uint32_t char32_t; * scrolling only implies some pointer shuffling. */ struct uni_screen { - char32_t *lines[0]; + DECLARE_FLEX_ARRAY(char32_t *, lines); }; static struct uni_screen *vc_uniscr_alloc(unsigned int cols, unsigned int rows) -- 2.34.1
| |