lkml.org 
[lkml]   [2023]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: platform: ti: Add missing check for devm_regulator_get
Hi Jiasheng,

Thank you for the patch.

On Wed, Jan 04, 2023 at 04:55:37PM +0800, Jiasheng Jiang wrote:
> Add check for the return value of devm_regulator_get since it may return
> error pointer.
>
> Fixes: 448de7e7850b ("[media] omap3isp: OMAP3 ISP core")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/media/platform/ti/omap3isp/isp.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/platform/ti/omap3isp/isp.c b/drivers/media/platform/ti/omap3isp/isp.c
> index 1d40bb59ff81..e7327e38482d 100644
> --- a/drivers/media/platform/ti/omap3isp/isp.c
> +++ b/drivers/media/platform/ti/omap3isp/isp.c
> @@ -2307,7 +2307,16 @@ static int isp_probe(struct platform_device *pdev)
>
> /* Regulators */
> isp->isp_csiphy1.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy1");
> + if (IS_ERR(isp->isp_csiphy1.vdd)) {
> + ret = PTR_ERR(isp->isp_csiphy1.vdd);
> + goto error;
> + }
> +
> isp->isp_csiphy2.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy2");
> + if (IS_ERR(isp->isp_csiphy2.vdd)) {
> + ret = PTR_ERR(isp->isp_csiphy2.vdd);
> + goto error;
> + }
>
> /* Clocks
> *

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2023-03-26 23:27    [W:0.032 / U:3.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site