Messages in this thread | | | Date | Tue, 31 Jan 2023 16:39:45 +0100 | Subject | Re: [PATCH v2 4/4] thermal: intel: int340x: Improve int340x_thermal_set_trip_temp() | From | Daniel Lezcano <> |
| |
On 30/01/2023 19:47, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Instead of using snprintf() to populate the ACPI object name in > int340x_thermal_set_trip_temp(), use an appropriate initializer > and make the function fail if its trip argument is greater than 9, > because ACPI object names can only be 4 characters long and it does > not make sense to even try to evaluate objects with longer names (that > argument is guaranteed to be non-negative, because it comes from the > thermal code that will not pass negative trip numbers to zone > callbacks). > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > ---
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |