Messages in this thread | | | Date | Tue, 31 Jan 2023 14:24:50 +0100 | Subject | Re: [PATCH v4 09/14] soc: mediatek: mtk-svs: improve readability of platform_probe | From | Matthias Brugger <> |
| |
On 11/01/2023 08:45, Roger Lu wrote: > From: Matthias Brugger <matthias.bgg@gmail.com> > > If a compatible misses a match data entry, then something is wrong in > the development phase, we don't need to check for that at runtime. > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: Roger Lu <roger.lu@mediatek.com>
Applied, thanks!
> --- > drivers/soc/mediatek/mtk-svs.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index 41c0ac5ed8d3..354582825082 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -2394,10 +2394,6 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev) > int ret; > > svsp_data = of_device_get_match_data(&pdev->dev); > - if (!svsp_data) { > - dev_err(&pdev->dev, "no svs platform data?\n"); > - return ERR_PTR(-EPERM); > - } > > svsp = devm_kzalloc(&pdev->dev, sizeof(*svsp), GFP_KERNEL); > if (!svsp)
| |