lkml.org 
[lkml]   [2023]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ASoC: da7219: Fix pole orientation detection on OMTP headsets when playing music
    On Mon, Jan 30, 2023 at 10:16:06PM -0800, Guenter Roeck wrote:
    > On 1/30/23 19:58, David Rau wrote:

    > > Thanks for the kind feedback.
    > > Would you please let me know what kinds of environment such error appears you ever meet?
    > > Ex: da7219_aad->gnd_switch_delay = ?

    > We are seeing the problem on various Chromebooks.

    > Never mind, though. I really don't have time to keep arguing about this.
    > I would have assumed that it is obvious that a long msleep() in an
    > interrupt handler is not appropriate, but obviously I was wrong.

    This is a threaded interrupt handler so it's a bit less clear that it's
    meaningfully different to just disabling the interrupt for debounce or
    whatever. Not to say it's ideal.

    > I'll see if I can implement a downstream fix.

    If you implement something I don't see a reason not to post it upstream.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-03-27 00:03    [W:3.016 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site