Messages in this thread | | | Date | Tue, 31 Jan 2023 15:09:06 +0530 | Subject | Re: [PATCH 2/6] clk: qcom: ipq9574: Enable APSS clock driver | From | Devi Priya <> |
| |
Thanks Dmitry for taking time to review the patch!
On 1/31/2023 2:59 PM, Dmitry Baryshkov wrote: > On 13/01/2023 16:36, devi priya wrote: >> Enable APSS clock driver for IPQ9574 based devices >> >> Co-developed-by: Praveenkumar I <quic_ipkumar@quicinc.com> >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >> Signed-off-by: devi priya <quic_devipriy@quicinc.com> >> --- >> drivers/clk/qcom/apss-ipq-pll.c | 13 +++++++++++++ >> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++ > > Note, the drivers/mailbox isn't a part of the 'drivers/clk', so it > should go to a separate patch (and it will be handled by a different > maintainer). > Sure, got it. will split the changes in V2 >> 2 files changed, 18 insertions(+) >> >> diff --git a/drivers/clk/qcom/apss-ipq-pll.c >> b/drivers/clk/qcom/apss-ipq-pll.c >> index a5aea27eb867..dd0c01bf5a98 100644 >> --- a/drivers/clk/qcom/apss-ipq-pll.c >> +++ b/drivers/clk/qcom/apss-ipq-pll.c >> @@ -61,6 +61,18 @@ static const struct alpha_pll_config >> ipq8074_pll_config = { >> .test_ctl_hi_val = 0x4000, >> }; >> +static const struct alpha_pll_config ipq9574_pll_config = { >> + .l = 0x3b, >> + .config_ctl_val = 0x200D4828, >> + .config_ctl_hi_val = 0x6, >> + .early_output_mask = BIT(3), >> + .aux2_output_mask = BIT(2), >> + .aux_output_mask = BIT(1), >> + .main_output_mask = BIT(0), >> + .test_ctl_val = 0x0, >> + .test_ctl_hi_val = 0x4000, >> +}; >> + >> static const struct regmap_config ipq_pll_regmap_config = { >> .reg_bits = 32, >> .reg_stride = 4, >> @@ -102,6 +114,7 @@ static int apss_ipq_pll_probe(struct >> platform_device *pdev) >> static const struct of_device_id apss_ipq_pll_match_table[] = { >> { .compatible = "qcom,ipq6018-a53pll", .data = >> &ipq6018_pll_config }, >> { .compatible = "qcom,ipq8074-a53pll", .data = >> &ipq8074_pll_config }, >> + { .compatible = "qcom,ipq9574-a73pll", .data = >> &ipq9574_pll_config }, >> { } >> }; >> MODULE_DEVICE_TABLE(of, apss_ipq_pll_match_table); >> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> b/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> index 0e9f9cba8668..90e74f9d7cb3 100644 >> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c >> @@ -33,6 +33,10 @@ static const struct qcom_apcs_ipc_data >> ipq6018_apcs_data = { >> .offset = 8, .clk_name = "qcom,apss-ipq6018-clk" >> }; >> +static const struct qcom_apcs_ipc_data ipq9574_apcs_data = { >> + .offset = 8, .clk_name = "qcom,apss-ipq6018-clk" >> +}; > > As the data is identical to ipq6018's one, please don't add a duplicate > of it. > Sure, okay >> + >> static const struct qcom_apcs_ipc_data msm8916_apcs_data = { >> .offset = 8, .clk_name = "qcom-apcs-msm8916-clk" >> }; >> @@ -143,6 +147,7 @@ static int qcom_apcs_ipc_remove(struct >> platform_device *pdev) >> static const struct of_device_id qcom_apcs_ipc_of_match[] = { >> { .compatible = "qcom,ipq6018-apcs-apps-global", .data = >> &ipq6018_apcs_data }, >> { .compatible = "qcom,ipq8074-apcs-apps-global", .data = >> &ipq6018_apcs_data }, >> + { .compatible = "qcom,ipq9574-apcs-apps-global", .data = >> &ipq9574_apcs_data }, >> { .compatible = "qcom,msm8916-apcs-kpss-global", .data = >> &msm8916_apcs_data }, >> { .compatible = "qcom,msm8939-apcs-kpss-global", .data = >> &msm8916_apcs_data }, >> { .compatible = "qcom,msm8953-apcs-kpss-global", .data = >> &msm8994_apcs_data }, > Best Regards, Devi Priya
| |