Messages in this thread Patch in this message | | | Date | Tue, 31 Jan 2023 17:57:23 -0800 | From | Saurabh Singh Sengar <> | Subject | Re: [PATCH v2 5/6] dt-bindings: hypervisor: Add dt-bindings for VMBus |
| |
On Tue, Jan 31, 2023 at 07:54:56PM +0100, Krzysztof Kozlowski wrote: > On 31/01/2023 19:10, Saurabh Sengar wrote: > > > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > > > + - | > > + / { > > + compatible = "foo"; > > + model = "foo"; > > + #address-cells = <0x02>; > > + #size-cells = <0x02>; > > Except previous comments (all of them were ignored),
Thank you for your comments, I have tried to address them all in this version but I may have missed few. I will go and look again all the emails, but if there is any thing which you can point again and we can start a new dicussion from here will be very helpful.
I think one concern was related to use of 'reg' or 'ranges', and I thought this patch will give clarity that I intend to use 'ranges' without any child node. Is this acceptable ?
> also: > Drop entire part. Not related, not correct, not helping and you cannot > have top level nodes in example.
If I dont use the top level node, the parent address cells are assumed to be 1, and I get below warning. If there is better way to address this warning, please suggest I will work on it.
Warning (ranges_format): /example-0/vmbus@ff0000000:ranges: "ranges" property has invalid length (20 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1)
> > > + > > + vmbus@ff0000000 { > > + #address-cells = <0x02>; > > + #size-cells = <0x01>; > > + compatible = "msft,vmbus"; > > + ranges = <0x00 0x00 0x0f 0xf0000000 0x10000000>; > > + }; > > + }; > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > index 1f7a519a936f..ab74ea97535f 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > @@ -876,6 +876,8 @@ patternProperties: > > deprecated: true > > "^mscc,.*": > > description: Microsemi Corporation > > + "^msft,.*": > > + description: Microsoft Corporation > > Don't duplicate vendor prefixes. Drop and use correct prefix.
Sure, will fix this.
Regards, Saurabh
> > Best regards, > Krzysztof
| |