Messages in this thread | | | Date | Tue, 31 Jan 2023 18:59:21 +0100 | Subject | Re: [PATCH v5] ASoC: dt-bindings: Add tas2781 amplifier. | From | Krzysztof Kozlowski <> |
| |
On 31/01/2023 14:17, Shenghao Ding wrote: > Create tas2781.yaml for tas2781 driver.
You treat my feedback selectively... some things improved, but not everything. I am literally repeating the same and expect different results from you... isn't that the definition of insanity?
Let me paste ignored parts:
1. Your patches are still not correctly threaded. There is no threading at all.
I said it multiple times. What else should I say here?
2. Subject: ASoC: dt-bindings: Add tas2781 amplifier (drop the full stop - why did you add it there?)
3. Missing changelog under ---. I mentioned it already few times, didn't I?
> > Signed-off-by: Shenghao Ding <13916275206@139.com> > > --- > Changes to be committed: > new file: Documentation/devicetree/bindings/sound/ti,tas2781.yaml > --- > .../devicetree/bindings/sound/ti,tas2781.yaml | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2781.yaml > > diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > new file mode 100644 > index 000000000..9a440d29f > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 - 2023 Texas Instruments Incorporated > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/ti,tas2781.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments TAS2781 SmartAMP > + > +maintainers: > + - Shenghao Ding <shenghao-ding@ti.com> > + - Kevin Lu <kevin-lu@ti.com> > + > +description: | > + The TAS2781 is a mono, digital input Class-D audio amplifier > + optimized for efficiently driving high peak power into small > + loudspeakers. Integrated an on-chip DSP supports Texas Instruments > + Smart Amp speaker protection algorithm. The integrated speaker > + voltage and current sense provides for real time > + monitoring of loudspeaker behavior. > + > +properties: > + compatible: > + enum: > + - ti,tas2781 > + > + reg: > + maxItems: 1 > + description: | > + I2C address of the device can be in range from 0x38 to 0x40. > + > + reset-gpios: > + maxItems: 1 > + description: | > + A GPIO line handling reset of the chip. As the line is active high, > + it should be marked GPIO_ACTIVE_HIGH (see ../gpio/gpio.txt)
Drop the reference to gpio.txt.
I give up. I spent too much time on it while being also ignored a bit too much.
Best regards, Krzysztof
| |