Messages in this thread | | | From | LI Qingwu <> | Subject | RE: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE | Date | Mon, 30 Jan 2023 07:44:22 +0000 |
| |
> -----Original Message----- > From: Abel Vesa <abel.vesa@linaro.org> > Sent: Sunday, January 29, 2023 2:39 AM > To: Stephen Boyd <sboyd@kernel.org>; LI Qingwu > <Qing-wu.Li@leica-geosystems.com.cn>; Peng Fan <peng.fan@nxp.com> > Cc: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>; abelvesa@kernel.org; > mturquette@baylibre.com; shawnguo@kernel.org; s.hauer@pengutronix.de; > kernel@pengutronix.de; festevam@gmail.com; linux-imx@nxp.com; > linux-clk@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; 18701859600@163.com; > GEO-CHHER-bsp-development <bsp-development.geo@leica-geosystems.com>; > Marco Felsch <m.felsch@pengutronix.de> > Subject: Re: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE > > [Some people who received this message don't often get email from > abel.vesa@linaro.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > This email is not from Hexagon's Office 365 instance. Please be careful while > clicking links, opening attachments, or replying to this email. > > > On 23-01-18 11:00:36, Stephen Boyd wrote: > > Quoting Abel Vesa (2023-01-16 06:28:33) > > > On 23-01-11 11:10:30, LI Qingwu wrote: > > > > Defined IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV in > imx8mp-clock.h > > > > but never assigned. It will cause the system to hang if using them. > > > > Alias IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV to > > > > IMX8MP_CLK_M7_CORE for backward compatibility. > > > > > > > > Fixes: 8c83a8ff4dd9 (clk: imx8mp: use imx8m_clk_hw_composite_core > > > > to simplify code) > > > > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > > > > Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > > > > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> > > > > > > Stephen, can you please pick this up yourself? > > > > > > > Is it needed for clk-fixes? When did the system start hanging? > > Li, Peng, can you provide some details here?
Since IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV were not assigned, if using any one of them in device tree, Linux system hanging after start M7 core.
| |