Messages in this thread | | | Date | Mon, 30 Jan 2023 10:39:18 +0100 | Subject | Re: [PATCH v3 2/3] ASoC: simple-card-utils: create jack inputs for aux_devs | From | Astrid Rost <> |
| |
On 1/27/23 13:19, Mark Brown wrote: > On Mon, Jan 23, 2023 at 02:59:12PM +0100, Astrid Rost wrote: >> Add a generic way to create jack inputs for auxiliary jack detection >> drivers (e.g. via i2c, spi), which are not part of any real codec. >> The simple-card can be used as combining card driver to add the jacks, >> no new one is required. >> >> Create a jack (for input-events) for jack devices in the auxiliary >> device list (aux_devs). A device which returns a valid value on >> get_jack_type counts as jack device; set_jack is required >> to add the jack to the device. >> >> Signed-off-by: Astrid Rost <astrid.rost@axis.com> >> --- >> include/sound/simple_card_utils.h | 3 ++ >> sound/soc/generic/simple-card-utils.c | 49 +++++++++++++++++++++++++++ >> sound/soc/generic/simple-card.c | 4 +++ >> 3 files changed, 56 insertions(+) > > Given that everyone is really supposed to be using the > audio-graph cards for new systems this should be hooked up there > too.
Hello,
Yes auxiliary devices are very useful, e.g. for GPIO. I can make a patch for audio-graph-card.c to add it.
Best Regards
Astrid
| |