[lkml]   [2023]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane transaction layer
Hi Jakub,

sorry for late response, please check following reply.

On Thu, 2023-01-19 at 19:52 -0800, Jakub Kicinski wrote:
> On Wed, 18 Jan 2023 19:38:55 +0800 Yanchao Yang wrote:
> > drivers/net/wwan/mediatek/mtk_dpmaif.c | 4005
> > ++++++++++++++++++++
> clang detects out-of-bound memcpy/strcpy or such somewhere in this
> file.
> Please fix that.
Ok, we will check and fix it.
> Please try to make the series smaller than 17,770 :/
> Strip stuff down to minimal working version.
> I don't think anyone can review 17kLoC in one sitting :/
Thank your suggestion. I agree with you. Considering both the control
plane and data plane are the minimal function for TMI driver, other
functions can be removed and submitted after the initial version is
approved. The whole patch can be reduced about 2k lines. Is it ok? Or
do you have any more suggestions? Please help share it.

Many thanks.
 \ /
  Last update: 2023-03-27 00:01    [W:0.116 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site