lkml.org 
[lkml]   [2023]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] MIPS: DTS: CI20: fix otg power gpio
From
Date
Hi Paul,

> Am 29.01.2023 um 19:08 schrieb Paul Cercueil <paul@crapouillou.net>:
>
> Hi Nikolaus,
>
> Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
> écrit :
>> According to schematics it is PF15 and not PF14 (MIC_SW_EN).
>> Seems as if it was hidden and not noticed during testing since
>> there is no sound DT node.
>>
>> Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
>> SoCs and boards.")
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> Looking at the schematics it looks like you are correct. So:
> Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks!

>
> I'm curious though, it is connected to the "SYS_POWER_IND" trace in the
> schematic, which seems to also switch the main led between red and
> blue, is that the case?

Yes, the LED changes between blue and red with this patch.

BR,
Nikolaus

>
> Cheers,
> -Paul
>
>> ---
>> arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
>> b/arch/mips/boot/dts/ingenic/ci20.dts
>> index 9819abb2465dd..a276488c0f752 100644
>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>> @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
>> regulator-min-microvolt = <5000000>;
>> regulator-max-microvolt = <5000000>;
>>
>> - gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
>> + gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
>> enable-active-high;
>> };
>> };
>

\
 
 \ /
  Last update: 2023-03-27 00:01    [W:0.059 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site