Messages in this thread Patch in this message |  | | Date | Sun, 29 Jan 2023 14:36:16 +0200 | From | Leon Romanovsky <> | Subject | Re: [net PATCH] octeontx2-af: Removed unnecessary debug messages. |
| |
On Fri, Jan 27, 2023 at 03:16:52PM +0530, Ratheesh Kannoth wrote: > From: Sunil Goutham <sgoutham@marvell.com> > > NPC exact match feature is supported only on one silicon > variant, removed debug messages which print that this > feature is not available on all other silicon variants.
I would say that this is net-next patch and not net. You simply remove debug prints.
> > Fixes: b747923afff8 ("octeontx2-af: Exact match support") > Signed-off-by: Sunil Goutham <sgoutham@marvell.com> > --- > .../ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > index f69102d20c90..2c832469229b 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > @@ -200,10 +200,8 @@ void npc_config_secret_key(struct rvu *rvu, int blkaddr) > struct rvu_hwinfo *hw = rvu->hw; > u8 intf; > > - if (!hwcap->npc_hash_extract) { > - dev_info(rvu->dev, "HW does not support secret key configuration\n"); > + if (!hwcap->npc_hash_extract) > return; > - } > > for (intf = 0; intf < hw->npc_intfs; intf++) { > rvu_write64(rvu, blkaddr, NPC_AF_INTFX_SECRET_KEY0(intf), > @@ -221,10 +219,8 @@ void npc_program_mkex_hash(struct rvu *rvu, int blkaddr) > struct rvu_hwinfo *hw = rvu->hw; > u8 intf; > > - if (!hwcap->npc_hash_extract) { > - dev_dbg(rvu->dev, "Field hash extract feature is not supported\n"); > + if (!hwcap->npc_hash_extract) > return; > - } > > for (intf = 0; intf < hw->npc_intfs; intf++) { > npc_program_mkex_hash_rx(rvu, blkaddr, intf); > @@ -1854,16 +1850,12 @@ int rvu_npc_exact_init(struct rvu *rvu) > /* Check exact match feature is supported */ > npc_const3 = rvu_read64(rvu, blkaddr, NPC_AF_CONST3); > if (!(npc_const3 & BIT_ULL(62))) { > - dev_info(rvu->dev, "%s: No support for exact match support\n", > - __func__); > return 0; > }
You need to remove { } brackets too.
> > /* Check if kex profile has enabled EXACT match nibble */ > cfg = rvu_read64(rvu, blkaddr, NPC_AF_INTFX_KEX_CFG(NIX_INTF_RX)); > if (!(cfg & NPC_EXACT_NIBBLE_HIT)) { > - dev_info(rvu->dev, "%s: NPC exact match nibble not enabled in KEX profile\n", > - __func__); > return 0; > }
Ditto.
> > @@ -2005,6 +1997,5 @@ int rvu_npc_exact_init(struct rvu *rvu) > (*drop_mcam_idx)++; > } > > - dev_info(rvu->dev, "initialized exact match table successfully\n"); > return 0; > } > -- > 2.25.1 >
|  |