[lkml]   [2023]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4] posix-timers: Prefer delivery of signals to the current thread

I agree with what you said, just one note...

On 01/27, Dmitry Vyukov wrote:
> After this change the test passes quickly (within a second for me).

yet perhaps it makes sense to slightly change it? It does

+static void *distribution_thr(void *arg) {
+ while (__atomic_load_n(&remain, __ATOMIC_RELAXED));
+ return NULL;

so distribution_thr() eats CPU even after this thread gets a signal and thus
(in theory) it can "steal" cpu_timer_fire() from other threads unpredictably
long ? How about

- while (__atomic_load_n(&remain, __ATOMIC_RELAXED));
+ while (__atomic_load_n(&got_signal, __ATOMIC_RELAXED));



 \ /
  Last update: 2023-03-27 00:00    [W:0.141 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site