Messages in this thread | | | Date | Sat, 28 Jan 2023 11:48:51 +0100 | Subject | Re: [PATCH v12 2/6] dt-bindings: thermal: mediatek: Add LVTS thermal controllers dt-binding definition | From | Krzysztof Kozlowski <> |
| |
On 26/01/2023 17:10, bchihi@baylibre.com wrote: > From: Balsam CHIHI <bchihi@baylibre.com> > > Add LVTS thermal controllers dt-binding definition for mt8195.
Subject: drop second/last, redundant "dt-binding definition". The "dt-bindings" prefix is already stating that these are bindings.
Plus two comments at the end.
> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > --- > Changelog: > v12: > - Fixed subject prefix > - Fixed licences GPL-2.0+ to GPL-2.0 > - Added dual licenses
> + }; > diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h > new file mode 100644 > index 000000000000..902d5b1e4f43 > --- /dev/null > +++ b/include/dt-bindings/thermal/mediatek-lvts.h
Same filename as bindings.
> @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */
Although this is correct, any reason why not using exactly the same license as bindings?
> +/* > + * Copyright (c) 2023 MediaTek Inc. > + * Author: Balsam CHIHI <bchihi@baylibre.com> > + */
Best regards, Krzysztof
| |