Messages in this thread | | | Date | Fri, 27 Jan 2023 15:32:35 +0000 | Subject | Re: [PATCH 0/4] perf intel-pt: Fix the pipe mode (v1) | From | James Clark <> |
| |
On 27/01/2023 00:19, Namhyung Kim wrote: > Hello, > > I found some problems in Intel-PT and auxtrace in general with pipe. > In the past it used to work with pipe, but recent code fails. As it > also touches the generic code, other auxtrace users like ARM SPE will > be affected too. I added a test case to verify it works with pipes. > > At last, I can run this command without a problem. > > $ perf record -o- -e intel_pt// true | perf inject -b | perf report -i- --itrace=i1000 > > The code is available at 'perf/auxtrace-pipe-v1' branch in > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git > > Thanks, > Namhyung > > Namhyung Kim (4): > perf inject: Use perf_data__read() for auxtrace > perf intel-pt: Do not try to queue auxtrace data on pipe > perf session: Avoid calling lseek(2) for pipe > perf test: Add pipe mode test to the Intel PT test suite > > tools/perf/builtin-inject.c | 6 +++--- > tools/perf/tests/shell/test_intel_pt.sh | 17 +++++++++++++++++ > tools/perf/util/auxtrace.c | 3 +++ > tools/perf/util/session.c | 9 +++++++-- > 4 files changed, 30 insertions(+), 5 deletions(-) > > For the whole set:
Reviewed-by: James Clark <james.clark@arm.com>
> base-commit: 5670ebf54bd26482f57a094c53bdc562c106e0a9 > prerequisite-patch-id: 4ccdf9c974a3909075051f4ffe498faecab7567b
| |